问题描述

我是完美主义者，我已经让网络 API 调用与 Google Places API 一起正常工作(仅作为示例)，但我觉得它有时很慢，或者我可能做得不对.一些博客说我应该使用 AndroidHttpClient，但我不是，应该吗?

I'm the perfectionist type, I already got web API calls working fine with Google Places API (just as an example), but I feel it's sometimes slow or maybe I'm not doing it right. Some blogs are saying I should use AndroidHttpClient, but I'm not, should I ?

Web API 调用我使用返回 json 并且我不在 UI 线程上运行它们，因此使用 AsyncTask(AsyncTask 是在后台线程上运行的最有效方法还是我应该使用其他方法?)

The web API calls i'm using return json and I don't run them on the UI thread, hence using AsyncTask (is AsyncTask the most efficient way to run on background thread or should I use something else ?)

请查看我的代码并告诉我如何才能更有效

Please see my code and tell me how could it be more efficient in anyway

public static class NearbySearchRequest extends AsyncTask<String, Void, JSONObject>
{
    Exception mException = null;

    @Override
    protected void onPreExecute()
    {
        super.onPreExecute();
        this.mException = null;
    }

    @Override
    protected JSONObject doInBackground(String... params)
    {
        StringBuilder urlString = new StringBuilder();
        urlString.append("https://maps.googleapis.com/maps/api/place/nearbysearch/json?");
        urlString.append("key=").append(Constants.GOOGLE_SIMPLE_API_KEY);
        urlString.append("&location=").append(params[0]);
        urlString.append("&sensor=").append("true");
        urlString.append("&language=").append("en-GB");
        urlString.append("&name=").append(params[1]);
        urlString.append("&rankby=").append("distance");

        LogHelper.Log(urlString.toString());

        HttpURLConnection urlConnection = null;
        URL url = null;
        JSONObject object = null;

        try
        {
            url = new URL(urlString.toString());
            urlConnection = (HttpURLConnection) url.openConnection();
            urlConnection.setRequestMethod("GET");
            urlConnection.setDoOutput(true);
            urlConnection.setDoInput(true);
            urlConnection.connect();
            InputStream inStream = null;
            inStream = urlConnection.getInputStream();
            BufferedReader bReader = new BufferedReader(new InputStreamReader(inStream));
            String temp, response = "";
            while ((temp = bReader.readLine()) != null)
                response += temp;
            bReader.close();
            inStream.close();
            urlConnection.disconnect();
            object = (JSONObject) new JSONTokener(response).nextValue();
        }
        catch (Exception e)
        {
            this.mException = e;
        }

        return (object);
    }

    @Override
    protected void onPostExecute(JSONObject result)
    {
        super.onPostExecute(result);

        if (this.mException != null)
            ErrorHelper.report(this.mException, "Error # NearbySearchRequest");
    }
}

推荐答案

您使用的 Http 引擎似乎是最佳选择.实际上，任何其他第 3 方引擎都基于 Apache，或者基于 HttpUrlConnection.我更喜欢使用 Spring for Android，因为该 API 提供了对 Http 引擎的抽象，而您却没有真的需要关心如何基于 API 级别使用什么 API.或者你可以使用 Volley——一个非常时尚的库.

The Http engine you're using seems the best choice. Actually any other 3-rd party engines are based either on Apache, either on HttpUrlConnection. I prefer to use Spring for Android as that API provide an abstraction over Http Engine and you don't really need to care how about what API to use based on API level. Or you can use Volley - a very fashionable library.

不过我会接触你的一些代码:

I would touch however some of your code:

1. 如果在读取流时出现异常怎么办?然后流保持打开状态，连接也保持打开状态.所以我建议在 finally 块中关闭流和连接，无论您是否遇到异常:

1. What if there is an exception while reading the stream? Then the stream remains open and also the connection. So I would suggest to have a finally block where the streams and connection is closed no matter if you get an exception or not:

HttpURLConnection urlConnection = null;
URL url = null;
JSONObject object = null;
InputStream inStream = null;
try {
    url = new URL(urlString.toString());
    urlConnection = (HttpURLConnection) url.openConnection();
    urlConnection.setRequestMethod("GET");
    urlConnection.setDoOutput(true);
    urlConnection.setDoInput(true);
    urlConnection.connect();
    inStream = urlConnection.getInputStream();
    BufferedReader bReader = new BufferedReader(new InputStreamReader(inStream));
    String temp, response = "";
    while ((temp = bReader.readLine()) != null) {
        response += temp;
    }
    object = (JSONObject) new JSONTokener(response).nextValue();
} catch (Exception e) {
    this.mException = e;
} finally {
    if (inStream != null) {
        try {
            // this will close the bReader as well
            inStream.close();
        } catch (IOException ignored) {
        }
    }
    if (urlConnection != null) {
        urlConnection.disconnect();
    }
}